fix: comment eslint disable in cypress config #4910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current cypress config has a global eslint-disable:
typescript
```
/* eslint-disable import/no-extraneous-dependencies, global-require, arrow-body-style */
// const webpack = require('@cypress/webpack-preprocessor')
```
But this assumes that `eslint-import-plugin` is present, whereas this is only true when the selected preset is the Airbnb one.
In other cases, this fails `yarn lint` right away with:
```
error: Definition for rule 'import/no-extraneous-dependencies' was not found (import/no-extraneous-dependencies) at tests/e2e/plugins/index.js```
Even if using the Airbnb preset, the comment does not have any effect, as, by default, the `require` call is commented.
This commit now splits the rules disabling in two:
- one commented for the people using Airbnb and who will uncomment the require call below, as it is only useful for them.
- one activated that disables `arrow-body-style` as it will fail the linting for people using Airbnb preset with the current config.
|
The fix looks good to me. But how did you encounter that error? I can't reproduce it on my machine. |
|
Sure, sorry, I forgot to provide the repro. Create a project with: Change the dependencies to use latest eslint, plugins and presets: "devDependencies": {
+ "@typescript-eslint/eslint-plugin": "2.10.0",
+ "@typescript-eslint/parser": "2.10.0",
"@vue/cli-plugin-e2e-cypress": "^4.1.0",
"@vue/cli-plugin-eslint": "^4.1.0",
"@vue/cli-plugin-typescript": "^4.1.0",
"@vue/cli-service": "^4.1.0",
- "@vue/eslint-config-prettier": "^5.0.0",
- "@vue/eslint-config-typescript": "^4.0.0",
- "eslint": "^5.16.0",
- "eslint-plugin-prettier": "^3.1.1",
- "eslint-plugin-vue": "^5.0.0",
+ "@vue/eslint-config-prettier": "6.0.0",
+ "@vue/eslint-config-typescript": "5.0.1",
+ "eslint": "6.7.2",
+ "eslint-plugin-prettier": "3.1.1",
+ "eslint-plugin-vue": "6.0.1",
"prettier": "^1.19.1",
"typescript": "~3.5.3",
"vue-template-compiler": "^2.6.10"
}(It's in fact enough to just bump to the latest Then install and run the linter: Throws: The fix should get rid of the issue for teams running the latest sets of eslint/plugins/config, |
mactanxin
pushed a commit
to mactanxin/vue-cli
that referenced
this pull request
Feb 11, 2020
The current cypress config has a global eslint-disable:
typescript
```
/* eslint-disable import/no-extraneous-dependencies, global-require, arrow-body-style */
// const webpack = require('@cypress/webpack-preprocessor')
```
But this assumes that `eslint-import-plugin` is present, whereas this is only true when the selected preset is the Airbnb one.
In other cases, this fails `yarn lint` right away with:
```
error: Definition for rule 'import/no-extraneous-dependencies' was not found (import/no-extraneous-dependencies) at tests/e2e/plugins/index.js```
Even if using the Airbnb preset, the comment does not have any effect, as, by default, the `require` call is commented.
This commit now splits the rules disabling in two:
- one commented for the people using Airbnb and who will uncomment the require call below, as it is only useful for them.
- one activated that disables `arrow-body-style` as it will fail the linting for people using Airbnb preset with the current config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current cypress config has a global eslint-disable:
typescript
But this assumes that
eslint-import-pluginis present, whereas this is only true when the selected preset is the Airbnb one.In other cases, this fails
yarn lintright away with:Even if using the Airbnb preset, the comment does not have any effect, as, by default, the
requirecall is commented.This commit now splits the rules disabling in two:
arrow-body-styleas it will fail the linting for people using Airbnb preset with the current config.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: